This revision was automatically updated to reflect the committed changes.
Closed by commit rL373470: [lldb] Fix evaluation of nested classes with parent
from other CU (authored by teemperor, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to co
teemperor added inline comments.
Comment at:
packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/TestNestedClassWithParentInAnotherCU.py:2
+"""
+Test that expression evaluator can access members of nested classes even if
+the parents of the nested classes
jarin added inline comments.
Comment at:
packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/TestNestedClassWithParentInAnotherCU.py:2
+"""
+Test that expression evaluator can access members of nested classes even if
+the parents of the nested classes wer
jarin updated this revision to Diff 222803.
jarin marked 5 inline comments as done.
jarin added a comment.
Fixed the nits, thanks for the careful review!
I will indeed need someone to submit this for me. Thanks in advance :-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68278/new/
htt
teemperor added a comment.
Just a few nitpicks about some minor typos, otherwise this LGTM. Thanks for the
patch! I assume you need someone to commit this for you?
Comment at:
packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/TestNestedClassWithParen
jarin updated this revision to Diff 222757.
jarin added a comment.
Fixed a typo.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68278/new/
https://reviews.llvm.org/D68278
Files:
packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/Makefile
packages/Python/ll
jarin updated this revision to Diff 222756.
jarin added a comment.
I have added some comments to the test (I hope it is not too overboard),
removed the LEVEL stuff from the Makefile and fixed the formatting.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68278/new/
https://reviews.llvm.
shafik added a comment.
The fix makes sense to me, I wonder if we have a similar issue w/ namespaces or
perhaps they are handled differently.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68278/new/
https://reviews.llvm.org/D68278
__
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
A few short comments what the role of the different classes/members play in the
test case would be helpful. E.g. "This member/variable/expressions triggers the
loading of Decl
labath added reviewers: clayborg, JDevlieghere.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: shafik.
Just a bit more context (we were discussing this with Jaroslav offline):
without this line, the `GetClangDeclCon
jarin created this revision.
Herald added subscribers: lldb-commits, JDevlieghere, teemperor.
Herald added a project: LLDB.
This makes sure that we associate DIEs that are imported from other CUs with
the appropriate decl context.
Without this fix, nested classes can be dumped directly into thei
11 matches
Mail list logo
