[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-11 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 224722. wallace added a comment. i think i finally wrote something that works python 2 and 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Pyt

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-11 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 224721. wallace added a comment. after the logging finally found the bug, it's was an encoding issue due to a different python version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.l

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-11 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 224717. wallace added a comment. adding some logging for exceptions in the mock server Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-11 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 224716. wallace added a comment. another try Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_cl

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-11 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 224703. wallace added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_clien

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-11 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 224656. wallace added a comment. now it should work, the test pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Python/lldbsuite/test/functio

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-08 Thread walter erquinigo via Phabricator via lldb-commits
wallace closed this revision. wallace added a comment. this was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-08 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. I reverted this change b/c the green dragon bots have been red for too long. When you fix the problem please make sure you add Differential Revision: https://reviews.llvm.org/D68354 to your commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-07 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. The windows LLDB bot also has the same failure: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9600 Please make sure your fix works for both. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/ne

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-07 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. damn, i'll rebase and try to fix it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-07 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. @wallace it looks like `TestPlatformClient.py` is failing on osx see green dragon log here: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2317/testReport/junit/lldb-Suite/functionalities_gdb_remote_client/TestPlatformClient_py/ ===

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-07 Thread walter erquinigo via Phabricator via lldb-commits
wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:30 +self.expect("platform process list -x", +startstr="1 matching

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-07 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LG, thanks for the test. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:30 +self.expect("platform proces

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-04 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 223358. wallace added a comment. added a basic python test It was a nice learning experience and fortunately there was no need to add any intrusive code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I think the fact that all of our options *must* have a short version is a pretty serious deficiency in our option parsing system. It results in a lot of unintuitive options that nobody uses because they can't guess what they stand for. But anyway, `-x` seems as good as a

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-02 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. Btw, I couldn't find a better short command than 'x', but if you have a better suggestion, i'd be happy to accept it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 __

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

2019-10-02 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: labath, xiaobai, aadsm, clayborg. Herald added subscribers: lldb-commits, atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: LLDB. For context: https://reviews.llvm.org/D68293 We need a way to show all the processes on