[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm added a comment. @shafik I just pushed a fix, the issue was because on mac there are more unnamed symbols so the number didn't match, I changed it to match any number since this can easily change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm added a comment. @shafik thanks, checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D68533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

shafik added a comment. `SymbolFile/Breakpad.symtab.test` is failing on green dragon cmake build see: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2378/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

This revision was automatically updated to reflect the committed changes. Closed by commit rGad6690afa3e6: Explicitly set entry point arch when it's thumb [Second Try] (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ htt

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm updated this revision to Diff 223707. aadsm added a comment. Don't destroy the Breakpad test purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D68533 Files: lldb/lit/SymbolFile/Breakpad/Inputs/basic

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

labath added inline comments. Comment at: lldb/lit/SymbolFile/Breakpad/symtab.test:20 # CHECK: Address: symtab.out[0x004000c0] (symtab.out.PT_LOAD[0]..text2 + 16) -# CHECK: Symbol: id = {0x}, range = [0x004000c0-0x004000d0), name="f2" +# CHECK:

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace, espindola. aadsm added a project: LLDB. This is a redo of D68069 because I reverted it due to some concerns that were now addressed along with the new comments that @labath added. I