[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224409. aprantl added a comment. and feedback from Jonas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

This revision was automatically updated to reflect the committed changes. Closed by commit rG418893d8f2f3: Speed up accelerator table lookups (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:116 // "std::vector::const_iterator") searching for the innermost // name alone ("const_iterator) could yield many false positives. By // searching for the parent

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds good, thanks for entertaining the extra fix and proving it didn't work! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224407. aprantl added a comment. Address feedback from Greg. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:138-143 } else if (has_tag) { if (log) m_module.LogMessage(log, "FindByNameAndTag()");

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

clayborg added a comment. So now we are doing two lookups each time we are doing a lookup? One idea to improve upon this would be to do this search a bit later on after we lookup "iterator" and only do this extra context matching if we find at last a certain number of results? So the flow

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl added a comment. I think this addresses all outstanding questions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224197. aprantl added a comment. Added a `if (!has_qualified_name_hash)`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp Index:

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl added a comment. (and my patch is meant primarily for the non-dsym case) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl added a comment. In D68678#1702418 , @clayborg wrote: > That qualified name hash the Apple tables used to avoid pulling in DWARF for > stuff that didn't match. Did this functionality stop working when accelerator > tables got refactored? The

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224193. aprantl added a comment. Address feedback from Jonas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

clayborg added a comment. That qualified name hash the Apple tables used to avoid pulling in DWARF for stuff that didn't match. Did this functionality stop working when accelerator tables got refactored? The .apple_types has a qualified name hash which is the hash of the complete type named

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:114 + + // When searching for "std::vector::const_iterator", reject any + // files without "vector" early, since there will be many other This comment

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224145. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile