This revision was automatically updated to reflect the committed changes.
Closed by commit rG95e264fc8a93: [lldb][NFC] Remove strange bool parameter from
Searcher::SearchCallback (authored by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
teemperor added a comment.
Thanks for the explanation! Doesn't seem like removing this breaks Swift, so
I'll land this.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68696/new/
https://reviews.llvm.org/D68696
___
jingham added a comment.
I have no memory of adding the 'addr' parameter.
If you had a search that was guaranteed to only return one address per
invocation, this would allow you to have the searcher coordinate gathering the
results, rather than having the callback record them on its own. That
jingham accepted this revision.
jingham added a comment.
One of the oddities of the Search -> Search callback stuff is that the
Searcher's Filter might be narrower than the level at which the Search Callback
wants to be invoked. The former is whatever the user actually wants limit the
search
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lol
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68696/new/
https://reviews.llvm.org/D68696
___
lldb-commits
teemperor added a comment.
I just realised the same is true for `addr` (beside that it is consistently
named). I'll remove this too after this has landed.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68696/new/
https://reviews.llvm.org/D68696
teemperor created this revision.
teemperor added reviewers: jingham, JDevlieghere, labath.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The SearchCallback has a bool parameter that we always set to false, we never
use in any callback implementation and that also changes
