[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

2019-10-10 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. In D68727#1703073 , @labath wrote: > I don't see harm in adding this, but I am curious about what are you planning > to use this for. My takeaway from all of the pexpect discussions we've had in > the past was that pexpect should

[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

2019-10-10 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't see harm in adding this, but I am curious about what are you planning to use this for. My takeaway from all of the pexpect discussions we've had in the past was that pexpect should

[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

2019-10-09 Thread Frederic Riss via Phabricator via lldb-commits
friss created this revision. friss added reviewers: teemperor, labath. Herald added a project: LLDB. This commit adds platform selection/connection commands to the base PExpectTest class. I doesn't look like any of the current tests are really interesting to test remotely, but it's easy enough to