[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a93a12a8dd9: [LLDB][Python] fix another fflush issue on NetBSD (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

labath accepted this revision. labath added a comment. Ok, let's get this thing fixed. We can continue the discussion on the other patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. WFM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny added a comment. Diff 4, I think. Lemme do a quick test with 5. Hopefully it won't request me to rebuild everything again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226747. lawrence_danna added a comment. revert to previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. In D69488#1724178 , @mgorny wrote: > I have confirmed that your previous revision fixed the problem in question. > The newer one would probably require full test suite run which I can't do > right now. As I said, I would

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny added a comment. I have confirmed that your previous revision fixed the problem in question. The newer one would probably require full test suite run which I can't do right now. As I said, I would prefer those two changes to be committed separately, preferably with a few hours delay so

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. In D69488#1723481 , @labath wrote: > I am not thrilled by all of that duping going around. Having multiple FILE > objects means that you have multiple independent file caches too. That can > cause different kinds of

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

labath added a comment. I am not thrilled by all of that duping going around. Having multiple FILE objects means that you have multiple independent file caches too. That can cause different kinds of strange behavior if multiple things start reading/writing to the different FILE objects

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny added a comment. Thanks but I'd personally prefer splitting this into a future commit, in case it introduced unrelated issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. There, I think that fixes the issue with borrow semantics and the NetBSD issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226618. lawrence_danna added a comment. protect python from being exposed to C++ reference borrowing semantics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:854 files = list(i(sbf)) +# delete them in reverse order, again because each

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:854 files = list(i(sbf)) +# delete them in reverse order, again because each

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny added a comment. I'm sorry but I won't be able to test it until later today. Visually, looks good though. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:854 files = list(i(sbf)) +# delete them in

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226599. lawrence_danna added a comment. and another Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226597. lawrence_danna added a comment. found another one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226595. lawrence_danna added a comment. py2_const_cast shouldn't be static as a free function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny. Herald added a subscriber: krytarowski. Herald added a project: LLDB. Here's another instance where we were calling fflush on an input stream, which is illegal on NetBSD. Repository: rG LLVM Github Monorepo