This revision was automatically updated to reflect the committed changes.
aprantl marked an inline comment as done.
Closed by commit rG0e45e60c6f31: Use ForEachExternalModule in
ParseTypeFromClangModule (NFC) (authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM minus some small changes.
Comment at: lldb/include/lldb/Symbol/SymbolFile.h:127
+ /// Apply a lambda to each external lldb::Module referenced by this
+ ///
aprantl created this revision.
aprantl added a reviewer: teemperor.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: shafik.
I wanted to further simplify ParseTypeFromClangModule by replacing the
hand-rolled loop with ForEachExternalModule, and then realized that