[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

mstorsjo added a comment. Just for the record, the issue seems to be this: $ cat cpp-ret-c.cpp template class MyClass { public: T a; }; extern "C" MyClass unmangledFunction(); $ cl -c cpp-ret-c.cpp cpp-ret-c.cpp cpp-ret-c.cpp(5): error C2526: 'unmangledFunction': C linkage

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

mstorsjo added a comment. In D70830#2742960 , @aganea wrote: > Hello @mstorsjo! I've reverted the patch locally, I'm at this commit: > > F:\aganea\llvm-project>git log > commit a3a8a1a15b524d91b5308db68e9d293b34cd88dd (HEAD -> main, origin/main) > > Us

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea added a comment. Hello @mstorsjo! I've reverted the patch locally, I'm at this commit: F:\aganea\llvm-project>git log commit a3a8a1a15b524d91b5308db68e9d293b34cd88dd (HEAD -> main, origin/main) Using: F:\aganea\llvm-project>cl Microsoft (R) C/C++ Optimizing Compiler Version 19.28

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

mstorsjo added a comment. Hi @aganea, I'm a but curious about this change - how did you manage to make this work with MSVC? In my experience, this construct doesn't produce warning C4190 (which this silences) with MSVC, but produces error C2526 (which I don't think can be silenced). See e.g. h

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cc0ba4cbdc5: [LLDB] Disable MSVC warning C4190: 'LLDBSwigPythonBreakpointCallbackFunction'… (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70830/new/ https://reviews.llvm.org/D70830 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea updated this revision to Diff 231455. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70830/new/ https://reviews.llvm.org/D70830 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp Index: l

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea created this revision. aganea added reviewers: JDevlieghere, lawrence_danna. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before this patch, when compiling with MSVC 15.9.17 (latest), we would see: F:\llvm-project\lldb\source\Plugins\ScriptInterpreter\Python\Sc