[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

This revision was automatically updated to reflect the committed changes. Closed by commit rG21d09ccf268d: [lldb-vscode] Ensure that target matches the executable file (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D708

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

clayborg accepted this revision. clayborg added a comment. Looks great, even more refactoring than asked. Thanks for sticking with this doing the work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70847/new/ https://reviews.llvm.org/D70847 ___

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov updated this revision to Diff 244160. anton.kolesov added a comment. Updated in attempt to reduce amount of code duplication between request_attach and request_launch. Built and tested with testsuite on Linux/x64, also built and manually tested on Windows/x64 host with a baremetal

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

labath added a comment. This approach looks good to me. It'd just be good to do something about the code duplication. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70847/new/ https://reviews.llvm.org/D70847 _

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Very nice, just need to add a VSCode::SetTarget(...) as detailed in inlined comments and this will be good to go. Comment at: lldb/tools/lldb-vscode/lldb-vscod

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov updated this revision to Diff 243828. anton.kolesov retitled this revision from "[lldb] Set executable module when adding modules to the Target" to "[lldb-vscode] Ensure that target matches the executable file". anton.kolesov edited the summary of this revision. anton.kolesov added

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov added a comment. In D70847#1763797 , @labath wrote: > This needs a test case, though judging by your description it looks like > pretty much every test case on affected platforms (I guess, windows) should > hit this. Can you check if any of

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

clayborg added a comment. The other fix would be to add a new LLDB API function: lldb::SBModule lldb::SBTarget::SetExecutable(const char *path, const char *triple, const char *symfile); Where we would pass in "nullptr" for "triple" and "symfile" from lldb-vscode and we call that. But I do th

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I think the fix is better done to fix the root cause issue instead of working around it. I have suggested a fix in inline comments. Comment at: lldb/tools/lldb

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

labath added a comment. This needs a test case, though judging by your description it looks like pretty much every test case on affected platforms (I guess, windows) should hit this. Can you check if any of the existing vscode tests which are marked @skipIfWindows start passing now? Repositor

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov created this revision. anton.kolesov added a project: LLDB. Herald added a subscriber: lldb-commits. Different architectures may use different target processes, so default "gdb-remote" target process created by lldb-vscode may not work for all targets. This commit changes behaviour o