JosephTremoulet updated this revision to Diff 231914.
JosephTremoulet added a comment.
- Change signature to return Expected>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70907/new/
https://reviews.llvm.org/D70907
Files:
jingham added a comment.
In other places, I've used "XList" to mean the container that manages the
things contained, and "XCollection" to be a random possibly unrelated
collection of items. It doesn't make any sense to have a collection of
breakpoints from more than one target, so the
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Breakpoint/BreakpointList.h:71
/// \bfalse if the input name was not a legal breakpoint name.
- bool FindBreakpointsByName(const char *name, BreakpointList _bps);
+ bool FindBreakpointsByName(const char
JosephTremoulet marked an inline comment as done.
JosephTremoulet added inline comments.
Comment at: lldb/include/lldb/Breakpoint/BreakpointList.h:71
/// \bfalse if the input name was not a legal breakpoint name.
- bool FindBreakpointsByName(const char *name,
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Breakpoint/BreakpointList.h:71
/// \bfalse if the input name was not a legal breakpoint name.
- bool FindBreakpointsByName(const char *name, BreakpointList _bps);
+ bool FindBreakpointsByName(const char
JosephTremoulet created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Using a BreakpointList corrupts the breakpoints' IDs because
BreakpointList::Add sets the ID, so use a vector instead.
Note that, despite the similar name,
