[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e9b0b6d11e8: [EditLine] Fix RecallHistory to make it go in the right direction. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

labath added a comment. In D70932#1766846 , @teemperor wrote: > Yes, multiline expressions use this code, but I don't see any functional > change in this patch that could be tested? It seems to only change the bool > to an enum so that we can pass in

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Yes, multiline expressions use this code, but I don't see any functional change in this patch that could be tested? It seems to only change the bool to an enum so that we can pass in

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

labath added a comment. In D70932#1766190 , @JDevlieghere wrote: > ... this code is only used by the REPL) Are you sure about that? I think I was able to trigger something like this by entering the multiline expression mode (`expr`) , and then

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

JDevlieghere added a comment. (No test because this code is only used by the REPL) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70932/new/ https://reviews.llvm.org/D70932 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath, teemperor, clayborg. Herald added a subscriber: abidh. Herald added a project: LLDB. The naming used by editline for the history operations is counter intuitive to how it's used in lldb for the REPL. - The H_PREV