kwk requested review of this revision.
kwk marked 2 inline comments as done.
kwk added a comment.
Addressed all review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71022/new/
https://reviews.llvm.org/D71022
kwk updated this revision to Diff 232494.
kwk added a comment.
- Review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71022/new/
https://reviews.llvm.org/D71022
Files:
lldb/source/Core/SearchFilter.cpp
Index:
teemperor accepted this revision.
teemperor added a comment.
I have one minor request (see inline comments), but otherwise LGTM, thanks!
Comment at: lldb/source/Core/SearchFilter.cpp:777
lldb::ModuleSP module_sp = target_images.GetModuleAtIndexUnlocked(i);
-if
JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Core/SearchFilter.cpp:625
modules_array);
FileSpecList modules;
+ if (!success)
kwk created this revision.
Herald added a reviewer: jdoerfert.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
kwk edited the summary of this revision.
I was working on SearchFilter.cpp and felt it a bit too complex in some cases
in terms of nesting and logic flow.
