[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath added a comment. Thanks. I believe this should be fixed by 0157a74be . I'll check the bot to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71770/new/

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

aprantl added a comment. Looks like this broke the ASAN bot? http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/783/testReport/junit/lldb-api/functionalities_breakpoint_comp_dir_symlink/TestCompDirSymLink_py/

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

aprantl added a comment. Looks like a missing nullptr check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71770/new/ https://reviews.llvm.org/D71770 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG27df2d9f556c: [lldb] Dont process symlinks deep inside DWARFUnit (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/include/lldb/Core/Module.h:972 + ModuleList::GetGlobalModuleListProperties() + .GetSymlinkMappings(); ///< Module specific source remappings for +

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/include/lldb/Core/Module.h:972 + ModuleList::GetGlobalModuleListProperties() + .GetSymlinkMappings(); ///< Module

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath requested review of this revision. labath edited reviewers, added: jingham; removed: jdoerfert. labath added a comment. Herald added a reviewer: jdoerfert. Re-requesting review, as this is essentially a different patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath updated this revision to Diff 237076. labath added a comment. Use a slightly different approach as the previous one didn't work on macos (the reason for that is that each .o file gets a separate module -- the patch populated the path map of the .o modules, but the remapping was being done

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cfb6677b2aa: [lldb] Dont process symlinks deep inside DWARFUnit (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71770/new/

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath added a comment. In D71770#1793334 , @aprantl wrote: > Does the mean these mappings will show up in the settings command? No, these won't show up in the target.source-map setting because this is setting the "per-module" mapping list, and not the

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

aprantl added a comment. Does the mean these mappings will show up in the settings command? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71770/new/ https://reviews.llvm.org/D71770 ___ lldb-commits

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. This code is handling debug info paths starting with /proc/self/cwd, which is one of the mechanisms people use to obtain "relocatable" debug