[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

This revision was automatically updated to reflect the committed changes. Closed by commit rG4706a60e8a07: [lldb] [testsuite] Fix Linux fail: Unwind/thread-step-out-ret-addr-check.test (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

labath added a comment. I didn't check this patch exactly, but I tried something very similar investigating this patch yesterday, so I think this should be fine. You should be able to see any darwin failures here: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/ Repository: rG LLVM

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil added a comment. Thanks for the review but is it tested on Darwin? I do not have any. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71784/new/ https://reviews.llvm.org/D71784 ___

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil updated this revision to Diff 235009. jankratochvil added a comment. Herald added a subscriber: krytarowski. Addressed the review and D71789 and enabled it for Linux again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

labath added a comment. As I said on the other patch, this is probably a simpler approach (assuming we can't find a way to make the data section non-executable in a generic way). You'll need to add an `#ifdef` for the section directive though... Comment at:

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

mossberg added a comment. The Windows failure (https://reviews.llvm.org/D71372#1793371) seems like it may also be caused by the underscore symbol issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71784/new/ https://reviews.llvm.org/D71784

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

mossberg added a comment. Thanks for looking into this @jankratochvil! > Another problem is that Fedora Linux has executable stack by default and all > programs indicate non-executable stack by PT_GNU_STACK, after fixing the > underscore I was getting: > > (lldb) thread step-out > Process

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil created this revision. jankratochvil added reviewers: jingham, labath, clayborg, mossberg. jankratochvil added a project: LLDB. Herald added a subscriber: kristof.beyls. D71372 introduced: `Unwind/thread-step-out-ret-addr-check.test` failing on