[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

This revision was automatically updated to reflect the committed changes. Closed by commit rG45c971f7eef1: [lldb/Lua] Make lldb.debugger et al available to Lua (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D71801?vs=236846=237093#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for your patience. Looks fine to me, just remove the dead code.. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:29-38 + +llvm::Error

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere updated this revision to Diff 236846. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Feedback Pavel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71801/new/ https://reviews.llvm.org/D71801 Files:

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere updated this revision to Diff 236845. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71801/new/ https://reviews.llvm.org/D71801 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:46 + m_lua(std::make_unique()) { + llvm::cantFail(GetLua().EnterSession(debugger.GetID())); +} JDevlieghere wrote: > labath wrote: > > I don't

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:46 + m_lua(std::make_unique()) { + llvm::cantFail(GetLua().EnterSession(debugger.GetID())); +}

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere updated this revision to Diff 236642. JDevlieghere added a comment. - Address feedback Pavel - Add test for nested session CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71801/new/ https://reviews.llvm.org/D71801 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

labath added a comment. In D71801#1807109 , @jingham wrote: > In D71801#1794758 , @labath wrote: > > > +Jim, for his thoughts on debugger+interpreter relationship > > > > I think this is the time to step back and

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

jingham added a comment. In D71801#1794758 , @labath wrote: > +Jim, for his thoughts on debugger+interpreter relationship > > I think this is the time to step back and discuss the relationship between > debugger and script interpreter contexts... I

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere updated this revision to Diff 235178. JDevlieghere added a comment. - Keep one set of convenience variables per lua state/script interpreter - Add test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71801/new/ https://reviews.llvm.org/D71801 Files:

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere planned changes to this revision. JDevlieghere added a comment. Thanks Pavel, I must admit I gave this little thought and just mirrored the Python approach. I *think* it should easy to implement things the way you describe (famous last words). CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

labath added a reviewer: jingham. labath added a comment. +Jim, for his thoughts on debugger+interpreter relationship I think this is the time to step back and discuss the relationship between debugger and script interpreter contexts... So, the way I understand the python code, our intention

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere updated this revision to Diff 235033. JDevlieghere added a comment. Test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71801/new/ https://reviews.llvm.org/D71801 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath. Herald added a project: LLDB. The Python script interpreter makes the current debugger, target, process, thread and frame available to interactive scripting sessions through convenience variables. This patch does