[Lldb-commits] [PATCH] D71824: Add the 'start' and 'length' to the completions response.

2019-12-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: clayborg. labath added a comment. This needs a test case, but I am also not sure that the implementation is correct even. What will this do with multiword commands "frame variable foo.b" ? Or even single-word commands that have multiple arguments ("vo foo bar foo.b")?

[Lldb-commits] [PATCH] D71824: Add the 'start' and 'length' to the completions response. This will fix an issue where applying a completion 'foo.bar' to 'po foo.b' inserts the entire completion result

2019-12-22 Thread Ivan Hernandez via Phabricator via lldb-commits
ivanhernandez13 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71824 Files: lldb/tools/lldb-vscode/lldb-vscode.cpp Index: lldb/tools/lldb-vscode/lldb-vscode.cpp