[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

labath added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:323-325 +// Treat this error as unrecoverable - we cannot be sure what any of +// the data represents including the length field, so cannot skip it or make +// any reasonable assump

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson marked an inline comment as done. jhenderson added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:323-325 +// Treat this error as unrecoverable - we cannot be sure what any of +// the data represents including the length field, so cann

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

labath added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:323-325 +// Treat this error as unrecoverable - we cannot be sure what any of +// the data represents including the length field, so cannot skip it or make +// any reasonable assump

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG7116e431c0ab: [DebugInfo] Make most debug line prologue errors non-fatal to parsing (authored by jhenderson). Changed prior to commit: https://reviews.llvm.org/D72158?vs=240852&id=241076#toc Repository

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson added a comment. Thanks for the review comments! I'll go ahead and land it like this, assuming my local test run passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72158/new/ https://reviews.llvm.org/D72158 ___

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Actually I think this is fine. We would want to squeeze as much information as possible from these kinds of line tables. I don't think fully preserving the existing behavior would be that easy

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson requested review of this revision. jhenderson added a comment. In D72158#1844534 , @labath wrote: > If I understand this correctly, this will cause lldb to continue to read the > parsed line table contribution after encountering some errors in

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

labath added a comment. If I understand this correctly, this will cause lldb to continue to read the parsed line table contribution after encountering some errors in the prologue, whereas previously we would stop straight away. That sounds reasonable if now or in the future we will be able to g

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson reopened this revision. jhenderson added a comment. This revision is now accepted and ready to land. Could somebody please look at the LLDB change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72158/new/ https://reviews.llvm.org/D72158

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson updated this revision to Diff 240852. jhenderson added a reviewer: labath. jhenderson added a comment. Herald added subscribers: lldb-commits, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. Fix LLD test + fix LLDB build. I'm uncertain if the LLDB fix is the r