jarin marked an inline comment as done.
jarin added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45
if (name_type_mask & eFunctionNameTypeFull) {
-dies.push_back(die);
-return;
+if (!die.IsMethod() || die.GetMangledName(false)
jarin marked an inline comment as done.
jarin added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45
if (name_type_mask & eFunctionNameTypeFull) {
-dies.push_back(die);
-return;
+if (!die.IsMethod() || die.GetMangledName(false)
labath added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45
if (name_type_mask & eFunctionNameTypeFull) {
-dies.push_back(die);
-return;
+if (!die.IsMethod() || die.GetMangledName(false) == name) {
+ dies.push_back(die);
jarin added a comment.
Pavel, does the latest patch address (and test) what you were worried about?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73191/new/
https://reviews.llvm.org/D73191
___
lldb-commits mailing list
jarin updated this revision to Diff 240144.
jarin edited the summary of this revision.
jarin added a comment.
Updated to include all methods/non-methods with matching mangled name.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73191/new/
https://reviews.llvm.org/D73191
Files:
labath added a comment.
This doesn't sound right. Will that mean we won't be able to find a method even
if we search for it by its proper full mangled name (e.g.
`_ZZ5ffbarvEN4sbaz3fooEv` in this case)?
A better heuristic might be to check for DW_AT_linkage_name, and if the DIE has
it, then
jarin created this revision.
jarin added a reviewer: labath.
jarin added a project: LLDB.
Herald added subscribers: lldb-commits, arphaman, aprantl.
In the spirit of https://reviews.llvm.org/D70846, we only return non-methods in
Apple/DebugNamesDWARFIndex::GetFunction if eFunctionNameTypeFull is
