[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e362d82b97f: Improve help text for (lldb) target symbols add (authored by amccarth). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D73589?vs=241013=242189#toc

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73589/new/ https://reviews.llvm.org/D73589 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

amccarth added a comment. This is low risk and it did get positive comments from one non-reviewer, so I'm going to land this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73589/new/ https://reviews.llvm.org/D73589 ___ lldb-commits

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

amccarth added a comment. In D73589#1845971 , @jasonmolenda wrote: > Looks good, for the --shlib option I would get rid of the "full path or base > name" language and just say "name", my two cents. I agree just "name" seems fine. Done. CHANGES

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

jasonmolenda added a comment. Looks good, for the --shlib option I would get rid of the "full path or base name" language and just say "name", my two cents. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73589/new/ https://reviews.llvm.org/D73589

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

amccarth created this revision. amccarth added a reviewer: aaron.ballman. There were some missing words and awkward syntax. I think this is clearer. https://reviews.llvm.org/D73589 Files: lldb/source/Commands/CommandObjectTarget.cpp Index: lldb/source/Commands/CommandObjectTarget.cpp