This revision was automatically updated to reflect the committed changes.
Closed by commit rG07355c1c08be: [lldb] Delete register info definitions in the
x86_64 ABI classes (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D74244?vs=244624&id=244942#toc
Repository:
rG L
labath updated this revision to Diff 244624.
labath marked 3 inline comments as done.
labath added a comment.
- make functions work on lowercase names
- handle singular registers in the remapping function
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
labath marked 6 inline comments as done.
labath added inline comments.
Comment at: lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp:938
+ .Case("R8", LLDB_REGNUM_GENERIC_ARG5)
+ .Case("r9", LLDB_REGNUM_GENERIC_ARG6)
+ .Default(LLDB_INVALID_REGNUM);
t
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Nice elimination of duplication.
Comment at: lldb/source/Target/ABI.cpp:249
+ int eh = -1;
+ int dwarf = -1;
+ for (unsigned reg = 0; reg < m_mc_register_info_
tatyana-krasnukha added inline comments.
Comment at: lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp:938
+ .Case("R8", LLDB_REGNUM_GENERIC_ARG5)
+ .Case("r9", LLDB_REGNUM_GENERIC_ARG6)
+ .Default(LLDB_INVALID_REGNUM);
Typo? It should be uppercase, I
labath created this revision.
labath added reviewers: JDevlieghere, jasonmolenda.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.
These definitions are used to "augment" information received from the remote
target with eh/debug frame and "generic" register numbers.
Besides being
