[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

stella.stamenova added a comment. In D74475#1875674 , @JDevlieghere wrote: > Yup, looks like that was it, the bot is green again: > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13740 Thanks for taking care of it! Repository: rG L

Re: [Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

Thanks, I thought I fixed that before committing (that was the one change that Pavel missed IIRC). > On 14. Feb 2020, at 07:53, Jonas Devlieghere via Phabricator > wrote: > > JDevlieghere added a comment. > > Yup, looks like that was it, the bot is green again: > http://lab.llvm.org:8011/bui

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

JDevlieghere added a comment. Yup, looks like that was it, the bot is green again: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13740 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74475/new/ https://reviews.llvm.org/D74475 __

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

JDevlieghere added a comment. In D74475#1874860 , @stella.stamenova wrote: > Either this change or D74243 broke the > windows bot and I do suspect D74243 but > have not confirmed it yet

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

stella.stamenova added a comment. Either this change or D74243 broke the windows bot and I do suspect D74243 but have not confirmed it yet: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13719 Repository: r

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

JDevlieghere added a comment. LGTM. I don't know how complex your script is, but could you include it in the commit message or the script directory so that we can run this again in the future? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74475/new/ https://reviews.llvm.org/D74475

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is a good idea. I have glanced over the patch, and I have found a couple of places where your script gets things wrong. They all involve doing boolean expressions in the assertion