This revision was automatically updated to reflect the committed changes.
Closed by commit rG6c17cc531f9f: [lldb] Make BreakpointResolver hold weak_ptr
instead of raw pointer to… (authored by tatyana-krasnukha).
Changed prior to commit:
https://reviews.llvm.org/D74557?vs=244727=248166#toc
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
You mean for BreakpointResolverScripted::CreateImplementationIfNeeded? Passing
in the BreakpointSP is fine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74557/new/
tatyana-krasnukha added a comment.
@jingham Is it Ok with you?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74557/new/
https://reviews.llvm.org/D74557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tatyana-krasnukha updated this revision to Diff 244727.
tatyana-krasnukha added a reviewer: jingham.
tatyana-krasnukha added a comment.
Just realized that BreakpointResolverScripted::CreateImplementationIfNeeded
should work when m_breakpoint == nullptr.
GetBreakpoint with assertion is not
tatyana-krasnukha updated this revision to Diff 244645.
tatyana-krasnukha added a comment.
Moved assertion into GetBreakpoint().
> Were there any places you found where it was legit to ask for the Breakpoint
> for a resolver and not have one?
I didn't find any, however, it seems to be possible
jingham added a comment.
I wonder if it wouldn't be better to assert in GetBreakpoint. Except when you
are making the resolver, you should never have a breakpoint resolver without a
valid breakpoint. And there's no point in calling GetBreakpoint when you know
you haven't set it yet. You
tatyana-krasnukha created this revision.
tatyana-krasnukha added reviewers: JDevlieghere, teemperor.
tatyana-krasnukha added a project: LLDB.
Herald added a subscriber: lldb-commits.
This prevents calling Breakpoint::shared_from_this of an object that is not
owned by any shared_ptr.
The patch
