This revision was automatically updated to reflect the committed changes.
Closed by commit rGf9568a95493a: [lldb][NFC] Make all CompilerDeclContext
parameters references instead of… (authored by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
teemperor updated this revision to Diff 244921.
teemperor added a comment.
- Readded some `parent_decl_context.IsValid()` checks to SymbolFilePDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74607/new/
https://reviews.llvm.org/D74607
Files:
lldb/include/lldb/Core/Module.h
teemperor marked an inline comment as done.
teemperor added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1133
-if (parent_decl_ctx && GetDeclContextContainingUID(
- result->getSymIndexId()) !=
shafik accepted this revision.
shafik added a comment.
This is a great change, it makes the code more consistent. LGTM besides the few
comments I made.
Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1133
-if (parent_decl_ctx &&
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Yes, please.
Bonus points to anyone who can replace the default-constructed
CompilerDeclContext with llvm::None.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
teemperor created this revision.
teemperor added reviewers: labath, mib.
Herald added subscribers: lldb-commits, JDevlieghere, abidh, arphaman.
Herald added a project: LLDB.
All of our lookup APIs either use `CompilerDeclContext &` or
`CompilerDeclContext *` semi-randomly it seems.
This leads to
