[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f820fa4feda: [lldb] Fix SourceManager::SourceFileCache insertion (authored by emrekultursay, committed by labath). Changed prior to commit: https://reviews.llvm.org/D76805?vs=252881=258737#toc

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay added a comment. In D76805#1949642 , @labath wrote: > Ok, that makes kind of sense, though I am left wondering if we really need > this feature, given that we have survived so long without noticing it is > missing... > > Am I understanding

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

labath added a comment. In D76805#1944198 , @emrekultursay wrote: > > Does this actually depend on the other patch? It looks like an independent > > fix we could commit separately. > > This bug seems to have existed forever. Fixing it means we will have

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252881. emrekultursay marked 3 inline comments as done. emrekultursay added a comment. Applied labath@'s suggestions on test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay added a comment. > Does this actually depend on the other patch? It looks like an independent > fix we could commit separately. This bug seems to have existed forever. Fixing it means we will have source file cache enabled for the first time. If it causes any unforeseen issues,

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

labath accepted this revision. labath marked an inline comment as done. labath added a comment. This revision is now accepted and ready to land. Looks good. I'm just picking some nits in the test. I'm assuming that @jingham's comment refers to the other patch (and it more-or-less matches what I

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252734. emrekultursay added a comment. Herald added a subscriber: mgorny. Add unit tests for SourceManager::SourceFileCache Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

jingham added a comment. IIUC, you should be able to test the actual effect you are trying to achieve by having a large source file, running "source list" to get it into the File Manager, then try to open the source file for writing in a process in a subshell that won't have the same mmap.

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

JDevlieghere added a comment. Could we add a unit test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.org/D76805 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252702. emrekultursay added a comment. fix link warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.org/D76805 Files: lldb/source/Core/SourceManager.cpp Index:

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. emrekultursay added a child revision: D76806: Remove m_last_file_sp from SourceManager. Lookup and subsequent insert was done using uninitialized FileSpec object, which caused the cache to