[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

This revision was automatically updated to reflect the committed changes. Closed by commit rGe796c77b26ac: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints… (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 256022. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good now. Sorry about the delay, I have a lot of things in my queue now and this got lost at the bottom of the stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace added a comment. Ping ping. This will fix some existing issues reported by users :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 ___ lldb-commits

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254280. wallace marked 2 inline comments as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Thanks for the updates and for writing the test. The code looks fine to me, the "request changes" is for making sure the test follows best practices and is portable.

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just use "llvm::None" instead of "{}" and this is good to go. Comment at: lldb/tools/lldb-vscode/JSONUtils.h:237 +CreateBreakpoint(lldb::SBBreakpoint , +

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254041. wallace added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace added a comment. Some included changes: - Removed the "source" element if the "breakpoint" object returned in breakpoint events - CreateBreakpoint now accepts an optional line number, which is used as fallback if no location is valid - Added a test that asserts breakpoints in

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254039. wallace added a comment. Account for dynamically loaded libraries and update the logic for breakpoint events Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

labath added a comment. In D76968#1951707 , @clayborg wrote: > Looks good as long as with we have "llvm::Optional > request_path = {}" in the arguments for a function, that "{}" will turn into > llvm::None and not an empty StringRef? Unclear to me. As

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

clayborg added a comment. Looks good as long as with we have "llvm::Optional request_path = {}" in the arguments for a function, that "{}" will turn into llvm::None and not an empty StringRef? Unclear to me. As long as this is what is happening and as long is this coding convention is used

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253779. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:332 + + object.try_emplace("line", line); + clayborg wrote: > This should do what it was doing before: grab the source line only from the

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. After reviewing more, we should just re-use CreateBreakpoint and add a "llvm::Optional request_path" argument. Then all breakpoints use the same function and we avoid duplicated

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253695. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253696. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The description confused me a bit as I thought we were going to be doing some "CommandObjectSource::DumpLinesInSymbolContexts()" stuff somewhere. But this path is really just

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253649. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py:25-43 +source_basename = 'main.cpp' +source_path = os.path.join(os.getcwd(), source_basename) + +

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py:25-43 +source_basename = 'main.cpp' +source_path = os.path.join(os.getcwd(), source_basename) + +new_source_folder =

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace created this revision. wallace added reviewers: clayborg, kusmour, labath, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 253283. wallace added a comment. cleanup When using source maps for a breakpoint, in order to

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253283. wallace added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: