[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

kwk added a comment. In D77108#1952039 , @labath wrote: > In D77108#1951997 , @kwk wrote: > > > In D77108#1951879 , @labath wrote: > > > > > Most DW_OP cases check their

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

djtodoro added a comment. In D77108#1952818 , @aprantl wrote: > For the future, a clean solution would be extending the macros in Dwarf.def > to list the stack effects in the definitions of the DW_OP_*, for example > > // opcode, name, version, vendor,

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

aprantl added a comment. CC'ing the DWARF cabal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77108/new/ https://reviews.llvm.org/D77108 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

labath added a comment. In D77108#1952818 , @aprantl wrote: > For the future, a clean solution would be extending the macros in Dwarf.def > to list the stack effects in the definitions of the DW_OP_*, for example > > // opcode, name, version, vendor,

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

aprantl added a comment. For the future, a clean solution would be extending the macros in Dwarf.def to list the stack effects in the definitions of the DW_OP_*, for example // opcode, name, version, vendor, in, out HANDLE_DW_OP(0x12, dup, 2, DWARF, 1, 2) and then we could write a static

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a7d790df33: [lldb/DWARF] Fix evaluator crash when accessing empty stack. (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77108/new/

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

mib updated this revision to Diff 253895. mib marked an inline comment as done. mib added a comment. Addressed Pavel's request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77108/new/ https://reviews.llvm.org/D77108 Files:

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

mib added a comment. In D77108#1951610 , @aprantl wrote: > This is obviously good! Do you think that a similar error handling bug might > exist in other cases that depend top-of-stack? I quickly ran through the function, and it seems this was the only

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

labath added a comment. In D77108#1951997 , @kwk wrote: > In D77108#1951879 , @labath wrote: > > > Most DW_OP cases check their stack, but it's quite possible that others > > were missed too. It might be a nice

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

kwk added a comment. In D77108#1951879 , @labath wrote: > In D77108#1951610 , @aprantl wrote: > > > This is obviously good! Do you think that a similar error handling bug > > might exist in other cases that depend

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

labath added a comment. In D77108#1951610 , @aprantl wrote: > This is obviously good! Do you think that a similar error handling bug might > exist in other cases that depend top-of-stack? Most DW_OP cases check their stack, but it's quite possible that

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This is obviously good! Do you think that a similar error handling bug might exist in other cases that depend top-of-stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

mib created this revision. mib added a reviewer: aprantl. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes a crash that happens on the DWARF expression evaluator when trying to access the top of the stack while it's empty. Signed-off-by: Med Ismail Bennani