[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd updated this revision to Diff 255581. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.h

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd updated this revision to Diff 255580. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.h Index:

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd added a comment. In D77287#1963242 , @labath wrote: > In D77287#1960390 , @compnerd wrote: > > > I think that the basic test is sufficient for this. > > > That test does not seem to be exercising the

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

labath added a comment. In D77287#1960390 , @compnerd wrote: > I think that the basic test is sufficient for this. That test does not seem to be exercising the "unload" part of this patch. It would also be nice to run some basic command like "image

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: lldb/test/Shell/Process/Windows/process_load.cpp:3 + +// REQUIRES: system-windows +// RUN: %build --compiler=clang-cl -o %t.exe -- %s JDevlieghere wrote: > We should probably

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd updated this revision to Diff 254883. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.h

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

JDevlieghere added inline comments. Comment at: lldb/test/Shell/Process/Windows/process_load.cpp:3 + +// REQUIRES: system-windows +// RUN: %build --compiler=clang-cl -o %t.exe -- %s We should probably have a `lit.local.cfg` in the Windows directory with ``` if

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd added a comment. Okay, thanks to some help from @JDevlieghere I was able to get a test going for this. I think that the basic test is sufficient for this. I think that the path sanitizing and conversion should be a subsequent change. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

labath added a comment. In D77287#1957472 , @compnerd wrote: > Thanks for the hint about the string conversion, however, I think that it's > going to complicate things as the string is going to be a mixture of UTF-8 > and UTF-16 content. That's true.

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd updated this revision to Diff 254631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.h Index:

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd added a comment. Thanks for the hint about the string conversion, however, I think that it's going to complicate things as the string is going to be a mixture of UTF-8 and UTF-16 content. As to the testing, `functionalities/load_using_paths/TestLoadUsingPaths.py` is not applicable to

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

labath added a comment. We have some existing tests (`functionalities/load_using_paths/TestLoadUsingPaths.py`) for this functionality, but they are are all skipped on windows. Can you check if they work now, or create a new test for the subset of functionality which does work? > Ideally,

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd created this revision. compnerd added reviewers: JDevlieghere, xiaobai. compnerd added a project: LLDB. Add some very basic support for `DoLoadImage` and `UnloadImage` for Windows. This was previously not implemented and would result in a failure at runtime that is hard to detect.