[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

This revision was automatically updated to reflect the committed changes. Closed by commit rGda0e91fee614: [intel-pt] Improve the way the test determines whether to run (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 257450. wallace added a comment. move the skipping logic to the actual test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files:

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

labath added a comment. Heh.. I wasn't an attempt expecting a fully generic solution. Since we don't invoke dotest.py manually these days (we have lldb-dotest for that) making a separate argument specifically for this plugin would be just fine. However, I don't see anything inherently wrong

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 256715. wallace edited the summary of this revision. wallace removed a reviewer: JDevlieghere. wallace removed a subscriber: JDevlieghere. wallace added a comment. Herald added a subscriber: mgorny. Addressed comments. The diff description now reflects the

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 256716. wallace added a comment. remove blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files: lldb/packages/Python/lldbsuite/test/configuration.py

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

labath added a reviewer: JDevlieghere. labath added a subscriber: JDevlieghere. labath added a comment. Adding @JDevlieghere as he is in the same time zone and knows about all this stuff. This is on the right track, but changing lldb-dotest is not enough -- you'll also need to change

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 255445. wallace edited the summary of this revision. wallace added a comment. See the new description of the diff for the updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

labath added a comment. Checking for presence this way seems ok-ish (definitely better than the environment variable). A possible alternative would be to pass some argument to dotest from cmake which would identify the status of the pt support. Anyway, if you're going to add a new public API

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 254990. wallace edited the summary of this revision. wallace added a comment. improve description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files:

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 254990. wallace edited the summary of this revision. wallace added a comment. improve description @labath raised