[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace abandoned this revision. wallace added a comment. Will revisit it whenever I need it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 ___ lldb-commits

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

jingham added a comment. In D77582#1967031 , @labath wrote: > In D77582#1966962 , @teemperor wrote: > > > I think the part of the patch that adds documentation to the existing > > method should go in (In general

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

labath added a comment. In D77582#1966962 , @teemperor wrote: > I think the part of the patch that adds documentation to the existing method > should go in (In general all patches that just add documentation have my > blanket approval, so please just

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

teemperor added a comment. I think the part of the patch that adds documentation to the existing method should go in (In general all patches that just add documentation have my blanket approval, so please just commit those). For the additional function: If you just change that CommandExists

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

shafik added a comment. I agree, if we don't have an immediate use then I don't think we should add it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

labath added a reviewer: jingham. labath added a comment. I don't have a hard objection to this, but if we're don't have a use for it, I don't see a need for adding it right now. Particularly as it sounds weird to me that "user commands" are not a subset of "commands". I know that is how the

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace updated this revision to Diff 255454. wallace added a comment. wallace updated this revision to Diff 255455. . wallace added a comment.

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace updated this revision to Diff 255455. wallace added a comment. Improve some names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 Files: lldb/bindings/interface/SBCommandInterpreter.i

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace updated this revision to Diff 255454. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 Files: lldb/bindings/interface/SBCommandInterpreter.i