This revision was automatically updated to reflect the committed changes.
Closed by commit rGb0bdaf9ba2bf: [lldb/Python] Add lldbconfig module to make
the lldb module configurable (authored by JDevlieghere).
Herald added a project: LLDB.
Changed prior to commit:
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Let's see how this goes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77661/new/
https://reviews.llvm.org/D77661
___
lldb-commits
JDevlieghere updated this revision to Diff 255792.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
Address code review feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77661/new/
https://reviews.llvm.org/D77661
Files:
lldb/bindings/python.swig
labath added a comment.
Thanks. This looks fine, just a question about the placement of the lldbconfig
module.
Comment at: lldb/CMakeLists.txt:130
+ "${LLDB_SOURCE_DIR}/bindings/python/lldbconfig.py"
+ "${python_build_path}/lldbconfig/__init__.py")
+
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:957
+import lldbconfig
import lldb
This is a NO-OP for now, but just shows that we can load the lldbconfig
JDevlieghere created this revision.
JDevlieghere added a reviewer: labath.
Herald added a subscriber: mgorny.
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:957
+import lldbconfig
