labath updated this revision to Diff 255916.
labath added a comment.
Cleaning up the patch. It should be ready now, I'm just going to give it one
more spin on windows.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77662/new/
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/make/dylib.h:50
+ FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM,
+ NULL, err, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
amccarth added a comment.
I like where this is going.
Comment at: lldb/packages/Python/lldbsuite/test/make/dylib.h:50
+ FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM,
+ NULL, err, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (char *), 0,
jingham added inline comments.
Comment at: lldb/test/API/functionalities/load_unload/TestLoadUnload.py:419
self.copy_shlibs_to_remote()
+env_cmd_string = "settings set target.env-vars " + self.dylibPath +
"=" + self.getBuildArtifact(".")
+
labath updated this revision to Diff 255727.
labath added a comment.
include some changes I forgot (they're the ones that need cleaning up the most)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77662/new/
https://reviews.llvm.org/D77662
Files:
labath created this revision.
labath added reviewers: amccarth, jingham, JDevlieghere, compnerd.
Herald added a project: LLDB.
labath updated this revision to Diff 255727.
labath added a comment.
include some changes I forgot (they're the ones that need cleaning up the most)
This is WIP because
