[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

2020-05-07 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdec1c94e801f: Add a function to detect whether an Xcode SDK supports Swift (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79535?vs=262699&id=2627

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

2020-05-07 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Nice test! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79535/new/ https://reviews.llvm.org/D79535 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

2020-05-07 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl updated this revision to Diff 262699. aprantl marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79535/new/ https://reviews.llvm.org/D79535 Files: lldb/include/lldb/Utility/XcodeSDK.h lldb/source/Utility/XcodeSDK.cpp lldb/unittests/Utility/Xcode

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

2020-05-07 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/include/lldb/Utility/XcodeSDK.h:70 llvm::StringRef GetString() const; + bool SupportsModules() const; + /// Whether this Xcode SDK supports Swift. JDevlieghere wrote: > Not implemented? I had another commit tha

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

2020-05-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/XcodeSDK.h:70 llvm::StringRef GetString() const; + bool SupportsModules() const; + /// Whether this Xcode SDK supports Swift. Not implemented? CHANGES SINCE LAST ACTION https://rev