[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

2020-05-28 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D79929#2058939 , @MrHate wrote: > That does make sense. I will split it into `eArgTypeProcessPlugin` and > `eArgTypeDisassemblePlugin` along with the corresponding completion function > names at the time I implement the

[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

2020-05-27 Thread Gongyu Deng via Phabricator via lldb-commits
MrHate marked an inline comment as done. MrHate added a comment. That does make sense. I will split it into `eArgTypeProcessPlugin` and `eArgTypeDisassemblePlugin` along with the corresponding completion function names at the time I implement the `disassemble` related completion function.

[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

2020-05-27 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. This change makes the eArgTypePlugin be the completion for process plugins. Shouldn't we change the enum name and completion name to indicate that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79929/new/

[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

2020-05-27 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG763bc2305797: [lldb] Tab completion for process plugin name (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit: