[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in SBTarget::AddModule

2020-05-28 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/API/SBTarget.cpp:1593 + llvm::StringRef rest = + UUID::DecodeUUIDBytesFromString(uuid_str, bytes, 20); + // If the UUID string was consumed and it is not empty, let us

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in SBTarget::AddModule

2020-05-28 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. SBTarget::AddModule currently handles the UUID parameter in a very weird way: UUIDs with more than 16 bytes are trimmed to 16 bytes. On the other hand, shorter-than-