[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

2020-06-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfac5d05eb75f: [lldb] Fix and enable Windows minidump tests (authored by jarin). Changed prior to commit: https://reviews.llvm.org/D81465?vs=269609=269649#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

2020-06-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 269609. jarin added a comment. Added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81465/new/ https://reviews.llvm.org/D81465 Files: lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py Index:

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

2020-06-09 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for getting back to this. I think this is a good workaround for the problem (maybe it would be good to make a note of that in the comment). The `fullpath` implementation should be

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

2020-06-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. jarin edited the summary of this revision. SBFileSpec.fullpath always uses the forward slash to join the directory with the base name. This causes mismatches when