[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda601ea731ec: [lldb/Test] Assert that no targets or modules remain after a test completes. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81612/new/ https://reviews.llvm.org/D81612 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

JDevlieghere added a comment. In D81612#2086939 , @labath wrote: > I'm pretty indifferent about this functionality -- I don't think it hurts, > but it also doesn't seem like a pressing problem that needs addressing. Yeah. I agree it's not a problem we

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

labath added a comment. I'm pretty indifferent about this functionality -- I don't think it hurts, but it also doesn't seem like a pressing problem that needs addressing. Regarding the implementation, be aware that assertion failures during test teardown are reproted pretty weirdly -- IIRC at

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

JDevlieghere updated this revision to Diff 270017. JDevlieghere added a comment. Address @vsk's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81612/new/ https://reviews.llvm.org/D81612 Files: lldb/bindings/interface/SBModule.i lldb/include/lldb/API/SBModule.h

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

vsk added inline comments. Comment at: lldb/bindings/interface/SBModule.i:347 +static uint32_t +GetNumberAllocatedModules(); Can we add a %feature("docstring", ...) blurb about this, advising script authors that it's probably not an API they're

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

JDevlieghere created this revision. JDevlieghere added reviewers: friss, labath, jingham, vsk. Herald added a subscriber: abidh. The reproducer intentionally leak every object allocated during replay, which means that modules never get orphaned. If this were to happen for another reason, we