[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. Hi Pavel, so I submitted the new patch(which I added you as a reviewer of) but it looks like the remote build failed. I ran `ninja check-lldb` locally and it works fine. How would I go about debugging this? I tried clicking on the links to the failed build, but couldn't

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. In D81697#2138024 , @bbli wrote: > F12311388: image.png > > Hi, so I think I got the fix working. Attached is a screenshot of the new > output, with title "Build Command Stdout Ouput". Should I

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. F12311388: image.png Hi, so I think I got the fix working. Attached is a screenshot of the new output, with title "Build Command Stdout Ouput". Should I submit a new pull request for this? Also just wondering, it seems you guys have

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. In D81697#2131004 , @bbli wrote: > > Ideally this error should include the actual command line > > So to clarify, you want to also print out the exact clang command/what flags > were passed to clang whenever compile errors happen?

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. > Ideally this error should include the actual command line So to clarify, you want to also print out the exact clang command/what flags were passed to clang whenever compile errors happen? > We have lots of areas that need improvement, so we can come up with >

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. In D81697#2129407 , @bbli wrote: > > For example, the thing that's annoying me now is that whenever a test fails > > in the "make" phase (e.g. a compile error), we only get an error message > > with the return status, and the

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. > For example, the thing that's annoying me now is that whenever a test fails > in the "make" phase (e.g. a compile error), we only get an error message with > the return status, and the original make invocation. Sure thing, how should I get started(in particular where in

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. In D81697#2127061 , @bbli wrote: > Hi, bumping my post from two weeks ago. The main question I had was: would it > be ok if I just brought over the Outcome object for the time being? Umm... I don't know... Maybe? I suppose it

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. Hi, bumping my post from two weeks ago. The main question I had was: would it be ok if I just brought over the Outcome object for the time being? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81697/new/

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. - Ohh ok, guess I should have gotten the point about catching all exceptions recursively clarified before I began. - From looking at the code for `subTest`, the error catching functionality comes from `Outcome_object.testPartExecutor` context manager, and the rest seems

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. it looks like the official python unittest framework has grown support of a subtest feature, which seems to be very similar to what we want here. It may make more sense to update to a newer framework rather than

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [LLDB] Hi, this is a patch for the proposed GSoC project "Add support for batch-testing to the LLDB testsuite". The project aimed to add continuation functionality when multiple assertions are