> On Jun 24, 2020, at 15:48, Walter wrote:
>
> I'll revert this patch. This seems to be the reason
Great thanks! What’s puzzling is that on some runs, it seems to find
, but on others it does not.
Cheers,
Florian
___
lldb-commits mailing list
I'll revert this patch. This seems to be the reason
Il Mer 24 Giu 2020, 6:27 AM Florian Hahn via Phabricator <
revi...@reviews.llvm.org> ha scritto:
> fhahn added a comment.
>
> I noticed that it appears that ` lldb-api ::
> tools/lldb-vscode/attach/TestVSCode_attach.py` is flaky and I noticed
fhahn added a comment.
I noticed that it appears that ` lldb-api ::
tools/lldb-vscode/attach/TestVSCode_attach.py` is flaky and I noticed it
failing spuriously relatively frequently
For example http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5519
failed with
FAIL: lldb-api ::
This revision was automatically updated to reflect the committed changes.
Closed by commit rG74ab1da0285f: Redo of Add terminateCommands to lldb-vscode
protocol (authored by Walter Erquinigo walterme...@fb.com).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
wallace updated this revision to Diff 271542.
wallace added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81978/new/
https://reviews.llvm.org/D81978
Files:
wallace updated this revision to Diff 271541.
wallace added a comment.
remove unwanted changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81978/new/
https://reviews.llvm.org/D81978
Files:
clayborg added inline comments.
Comment at:
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:221-223
+elif packet_type == 'response':
+if packet['command'] == 'disconnect':
+keepGoing = False
revert
aadsm accepted this revision.
aadsm added a comment.
This revision is now accepted and ready to land.
Thank you for this! <3
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81978/new/
https://reviews.llvm.org/D81978
wallace created this revision.
wallace added reviewers: clayborg, aadsm, kusmour, labath.
wallace added a project: LLDB.
wallace edited the summary of this revision.
wallace added a parent revision: D81200: [vscode] set default values for
terminateDebuggee for the disconnect request.
This redoes
