This revision was automatically updated to reflect the committed changes.
Closed by commit rG58d84eb53425: debugserver: Support ios simulator load
command disambiguation in qProcessInfo (authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lldb/tools/debugserver/source/DNB.cpp:1396
if (GetProcessSP(pid, procSP)) {
-// FIXME: This doesn't correct for older ios simulator and macCatalyst.
+
aprantl updated this revision to Diff 280307.
aprantl added a comment.
Update comment. I wonder if it is feasible to give the macCatalyst code the
same treatment. It's more tricky because supporting zippered objects would
force some additional state into the function.
CHANGES SINCE LAST
aprantl created this revision.
aprantl added reviewers: friss, davide, jasonmolenda.
This patch basically moves the disambiguation code from a place where it was
complicated to implement straight to where the load command is parsed, which
has the neat side affect of actually supporting all call
