[Lldb-commits] [PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

labath added a comment. In D84748#2178809 , @ldionne wrote: > Can you confirm that all the targets that need to "link" (in the CMake sense) > against gtest use the gtest CMake target? I wouldn't use the word "confirm" but I did check that I am able to

[Lldb-commits] [PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb91c9fe7b62: [cmake] Make gtest macro definitions a part the library interface (authored by labath). Herald added a subscriber: JDevlieghere.

[Lldb-commits] [PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Can you confirm that all the targets that need to "link" (in the CMake sense) against gtest use the gtest CMake target? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

labath created this revision. labath added reviewers: ldionne, logan-5, beanz. Herald added subscribers: lldb-commits, dexonsmith, hiraditya, mgorny. Herald added projects: LLDB, LLVM. labath requested review of this revision. These definitions are needed by any file which uses gtest. Previously