[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

krytarowski added a comment. Please note that ncurses is not the only supported curses library. NetBSD uses its original BSD curses for LLVM projects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

gkistanova accepted this revision. gkistanova added a comment. This revision is now accepted and ready to land. Statically linked LLVM + LLD builds with this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie updated this revision to Diff 288864. haampie added a comment. Herald added a subscriber: danielkiss. Another take on this isuse, incorporating @phosek's comment on making find_library not find shared libs when compiling with `LLVM_BUILD_STATIC=ON`, and making sure that

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c7bfbd6831b: [CMake] Use find_library for ncurses (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

phosek accepted this revision. phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

phosek added a comment. In D85820#2235461 , @haampie wrote: > @gkistanova It's true that this change has lead to more issues I could ever > imagine, but I think the link you provided is the last remaining problem. > > Pinging @phosek for a similar issue

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

gkistanova reopened this revision. gkistanova added a comment. This revision is now accepted and ready to land. @haampie Are you working on fixing the http://lab.llvm.org:8011/builders/lld-perf-testsuite bot? This patch has broken it. FAILED: bin/llvm-tblgen : && /usr/bin/c++

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added a comment. @gkistanova It's true that this change has lead to more issues I could ever imagine, but I think the link you provided is the last remaining problem. Pinging @phosek for a similar issue w.r.t. zlib: since https://reviews.llvm.org/D79219 zlib gets disabled on static

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

srj added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO} srj

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

gribozavr2 added a comment. @haampie It looks like this change caused a build problem with OCaml enabled. Before: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/34606 After: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/34607 Could you take a look?

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO}

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

srj added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO} In

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

srj added a comment. This seems to have injected a link-time dependency on `setupterm` etc. even if you configure CMake with LLVM_ENABLE_TERMINFO=OFF (which was not the case before) -- this is breaking some builds of Halide as a result. (Should the `#idef LLVM_ENABLE_TERMINFO` actually if

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

yehenrytian added a comment. It looks like this change is causing a "regression" for MLIR tests: https://mlir.llvm.org/getting_started/ git clone https://github.com/llvm/llvm-project.git mkdir llvm-project/build cd llvm-project/build cmake -G Ninja ../llvm \

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added a comment. @gribozavr2: can you try https://reviews.llvm.org/D86134? It should fix your issue, as well as the same issue w.r.t. the ZLIB changes of https://reviews.llvm.org/D79219 on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added a comment. @srj could you please try / review https://reviews.llvm.org/D86173 for a fix for your problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

This revision was automatically updated to reflect the committed changes. Closed by commit rGa52173a3e565: Use find_library for ncurses (authored by haampie, committed by JDevlieghere). Herald added projects: Sanitizers, LLDB. Herald added subscribers: lldb-commits, Sanitizers. Repository: rG

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

RKSimon added a comment. @haampie @JDevlieghere This is failing on several buildbots please can you take a look : http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/13553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION