[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0de146337391: [lldb] Fix Type::GetByteSize for pointer types (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

labath added a comment. In D86436#2234110 , @davide wrote: > @labath something I noticed when finding this (and related bugs) is that > `frame var` carries a decent diagnostic > > (int *) l_125 = > > and the expression parser returns something not

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } shafik wrote: > labath wrote: > > davide wrote: > > > shafik wrote: > > > > Wouldn't it be better to turn

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added a subscriber: teemperor. davide added a comment. @labath something we noticed when finding this (and related bugs) is that `frame var` carries a decent diagnostic (int *) l_125 = and the expression parser returns just returns something not particularly useful: (lldb) p

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

shafik added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } labath wrote: > davide wrote: > > shafik wrote: > > > Wouldn't it be better to turn `m_byte_size` into an

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } shafik wrote: > Wouldn't it be better to turn `m_byte_size` into an `Optional`? As this fix > shows this

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

labath added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } shafik wrote: > Wouldn't it be better to turn `m_byte_size` into an `Optional`? As this fix > shows this

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

shafik added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } Wouldn't it be better to turn `m_byte_size` into an `Optional`? As this fix shows this having this additional

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I came to the same conclusion when analyzing https://bugs.llvm.org/show_bug.cgi?id=47257 (but you beat me to the punch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

labath created this revision. labath added reviewers: aprantl, shafik. Herald added a project: LLDB. labath requested review of this revision. Herald added a subscriber: JDevlieghere. The function was returning an incorrect (empty) value on the first invocation. Given that this only affected the