This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG82139b8770ee: Simplify Symbol Status Message to Only Debug
Info
wallace added a comment.
All module information is only displayed in our custom VSCode. Vanilla VSCode
doesn't have support for displaying modules.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86662/new/
https://reviews.llvm.org/D86662
clayborg added a comment.
So we are adding a custom new "debugInfoSize" field to the "module" JSON
dictionary? What happens in the release VS code? Does this information not get
displayed, but it will get displayed in our custom modified VS Code IDE?
Repository:
rG LLVM Github Monorepo
aelitashen updated this revision to Diff 288456.
aelitashen added a comment.
Keep symbol status till new version released, remove comments in tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86662/new/
https://reviews.llvm.org/D86662
Files:
aprantl added a comment.
Sorry, I missed this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86662/new/
https://reviews.llvm.org/D86662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
wallace added inline comments.
Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:44
+# symbol_regex = re.compile(r"Symbols loaded.
\([0-9]+(\.[0-9]*)?[KMG]?B\)")
+symbol_regex = re.compile(r"[0-9]+(\.[0-9]*)?[KMG]?B")
aprantl added a comment.
Could you please also include a testcase?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86662/new/
https://reviews.llvm.org/D86662
___
lldb-commits mailing list
wallace requested changes to this revision.
wallace added a comment.
This revision now requires changes to proceed.
For the record, this came out of discussion in which the consensus was to
display less characters and maximize the relevant information, which in this
case is just the debug info
aelitashen created this revision.
aelitashen added reviewers: wallace, clayborg.
Herald added subscribers: lldb-commits, aprantl.
Herald added a project: LLDB.
aelitashen requested review of this revision.
Herald added a subscriber: JDevlieghere.
The Symbol Status in modules view is simplified so
