[Lldb-commits] [PATCH] D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG80b108f404fc: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers

mgorny updated this revision to Diff 295869. mgorny marked an inline comment as done. mgorny added a comment. Fix mistype. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88681/new/ https://reviews.llvm.org/D88681 Files:

[Lldb-commits] [PATCH] D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:954 case lldb_foseg_x86_64: -m_fpr.fxstate.fx_dp.fa_64 = reg_value.GetAsUInt64(); +m_fpr.fxstate.fx_dp.fa_32.fa_seg = reg_value.GetAsUInt64();

[Lldb-commits] [PATCH] D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers

mgorny added a comment. Yes. We also need to fix our kernel but it's no less broken than it was before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88681/new/ https://reviews.llvm.org/D88681 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm assuming this is tested by D88583 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88681/new/ https://reviews.llvm.org/D88681

[Lldb-commits] [PATCH] D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers

mgorny created this revision. mgorny added reviewers: krytarowski, labath. mgorny requested review of this revision. Fix reading FIP/FDP registers to correctly return segment and offset parts. On amd64, this roughly matches the Linux behavior of splitting the 64-bit FIP/FDP into two halves, and