[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. I've commited one more fix here: https://reviews.llvm.org/rG97e7fbb343e2 - This didn't occur locally on my machine, but only on another machine. But in essence, the issue was the same, an accentuated Windows-1252 codepage character that was being decoded as UTF-8 by the

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79809f58b024: [LLDB] On Windows, fix tests (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D88975?vs=296809=296982#toc

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea marked 2 inline comments as done. aganea added a comment. Thank you all for your time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88975/new/ https://reviews.llvm.org/D88975 ___ lldb-commits

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317494 , @amccarth wrote: > It's interesting that I haven't encountered some of these errors. There are > five _other_ lldb tests that do fail for me. I have a fix in the works for > some of those. Please see my

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea updated this revision to Diff 296809. aganea marked an inline comment as done. aganea added a comment. As discussed above: - Remove locale-specific messages. - Skip relevant locale-sensitive TestTargetCommand tests. - Only skip EXPECT calls in Utility/StatusTest. Repository: rG LLVM

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317566 , @labath wrote: > I really want to avoid having language specific strings in the tests. We all agree on that. I'll update the patch once it passes all tests on my machines. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

labath added a comment. I really want to avoid having language specific strings in the tests. Skipping tests which depend on these is a reasonable approach (as you've discovered, there shouldn't be that many of them -- it's really just the tests which check that we actually can retrieve the

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317494 , @amccarth wrote: > Maybe dotest.py could change its own Windows locale setting and the processes > it spawns would inherit that. I don't know if that would work, but I don't > see a good alternative. One

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

amccarth added a comment. It's interesting that I haven't encountered some of these errors. There are five _other_ lldb tests that do fail for me. I have a fix in the works for some of those. I agree with @labath that including error message patterns in various languages isn't scalable.

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

labath added a comment. Is there a way to force a program to use a specific locale, ignoring the system-wide setting (something like `export LC_ALL=C` on unix)? Hardcoding the error message for all locales is not a viable long term strategy... :/ Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea created this revision. aganea added reviewers: amccarth, labath. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aganea requested review of this revision. This patch fixes a few issues seen when running `ninja check-lldb` in a