This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8a203bb22d16: [trace] rename ThreadIntelPT into TraceTrace
(authored by Walter Erquinigo wall...@fb.com).
Repository:
rG LLVM Github Monorepo
vsk added inline comments.
Comment at: lldb/include/lldb/Target/ThreadTrace.h:34
+ /// this thread was being executed.
+ ThreadTrace(Process , lldb::tid_t tid, const FileSpec trace_file)
+ : Thread(process, tid), m_trace_file(trace_file) {}
wallace
wallace added inline comments.
Comment at: lldb/include/lldb/Target/ThreadTrace.h:34
+ /// this thread was being executed.
+ ThreadTrace(Process , lldb::tid_t tid, const FileSpec trace_file)
+ : Thread(process, tid), m_trace_file(trace_file) {}
vsk
wallace updated this revision to Diff 298766.
wallace added a comment.
address comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89408/new/
https://reviews.llvm.org/D89408
Files:
lldb/include/lldb/Target/ProcessTrace.h
vsk added inline comments.
Comment at: lldb/include/lldb/Target/ThreadTrace.h:34
+ /// this thread was being executed.
+ ThreadTrace(Process , lldb::tid_t tid, const FileSpec trace_file)
+ : Thread(process, tid), m_trace_file(trace_file) {}
`const
clayborg added a comment.
LGTM. Pavel?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89408/new/
https://reviews.llvm.org/D89408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
