[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

2020-10-28 Thread Vedant Kumar via Phabricator via lldb-commits
vsk abandoned this revision. vsk added a comment. Jonas walked me through some of the issues here offline: - Looks like this makes testing depend on having a configured lldb-env tool, this will make it hard to run testing against an lldb root. - If we need to launch ./bin/lldb in some other work

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

2020-10-28 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. >> Re: making the lit.site.cfg self-contained, IIUC the situation is that there >> are a couple places where we shell out via `subprocess`, but that you'd like >> to get rid of these? I wonder whether we could bundle up the necessary >> scripts along with lit.site.cfg inste

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

2020-10-27 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D90276#2358016 , @vsk wrote: > In D90276#2357978 , @JDevlieghere > wrote: > >> Can you explain the added value of the tool a bit more. I can see how it's >> nice to be able to run

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

2020-10-27 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. In D90276#2357978 , @JDevlieghere wrote: > Can you explain the added value of the tool a bit more. I can see how it's > nice to be able to run `export $(lldb-env); path/to/lldb` but I wonder how > often you'd end up doing that. When

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

2020-10-27 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Can you explain the added value of the tool a bit more. I can see how it's nice to be able to run `export $(lldb-env); path/to/lldb` but I wonder how often you'd end up doing that. When I invoke lldb directly, it's mostly to debug a test case, in which case I'd nee

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

2020-10-27 Thread Vedant Kumar via Phabricator via lldb-commits
vsk created this revision. vsk added reviewers: JDevlieghere, teemperor, mgorny. Herald added a project: LLDB. vsk requested review of this revision. Introduce lldb-env, a tool that prints out the environment variables needed to launch lldb. Usually, no environment variables need to be set to lau