[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src; mgorny wrote: >

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny updated this revision to Diff 305545. mgorny added a comment. Port NetBSD plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny updated this revision to Diff 305536. mgorny added a comment. Move the functions into a new file, add comment, use `llvm::ArrayRef`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files:

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src; labath wrote: >

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

labath added a comment. Looks reasonable to me. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src;

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny added a comment. I'll port to other platforms once we agree on the approach. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Translate between abridged and full ftag values in order to expose the latter in the gdb-remote protocol while the former are used by FXSAVE/XSAVE... This matches the gdb