[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd055e3a0eb4e: [LLDB/Python] Fix segfault on Python scripted entrypoints (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92249/new/ https://reviews.llvm.org/D92249 _

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela updated this revision to Diff 308608. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92249/new/ https://reviews.llvm.org/D92249 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpr

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela added a comment. In D92249#2422205 , @labath wrote: > In D92249#2421639 , @JDevlieghere > wrote: > >> It appears there are many similar calls in this file, can you update those >> as well? > > If there are

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

labath added a comment. In D92249#2421639 , @JDevlieghere wrote: > It appears there are many similar calls in this file, can you update those as > well? If there are many of these calls, adding a static helper function for this purpose might be a good

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

JDevlieghere added a comment. It appears there are many similar calls in this file, can you update those as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92249/new/ https://reviews.llvm.org/D92249 ___

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. The code that calls into the ScriptInterpreter was not considering the case that it receives a Lua interpreter.